Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11055009: Converting NodeList to List<Node>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/scripts/generator.py ('k') | lib/html/templates/html/impl/impl_DocumentFragment.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index cfd925804b04375d27541014fbbe2d3270c4a32b..7fe8f9f499ee2ff689824b784df34a73f75fd3a2 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -500,6 +500,9 @@ class Dart2JSBackend(BaseGenerator):
pass
elif IsPureInterface(supertype):
pass
+ elif supertype == 'NodeList':
+ # Special case as NodeList gets converted to List<Node>.
Emily Fortuna 2012/10/03 00:46:21 These lines shouldn't be necessary. You added Node
+ base = '_NodeListImpl'
else:
base = self._ImplClassName(self._DartType(supertype))
@@ -940,7 +943,8 @@ class Dart2JSBackend(BaseGenerator):
def _ShouldNarrowToImplementationType(self, type_name):
# TODO(sra): Move into the 'system' and cache the result.
do_not_narrow = ['DOMStringList', 'DOMStringMap', 'EventListener',
- 'IDBAny', 'IDBKey', 'MediaQueryListListener']
+ 'IDBAny', 'IDBKey', 'MediaQueryListListener', 'List<Node>',
+ 'NodeList']
if type_name in do_not_narrow:
return False
if self._database.HasInterface(type_name):
« no previous file with comments | « lib/html/scripts/generator.py ('k') | lib/html/templates/html/impl/impl_DocumentFragment.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698