Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Issue 11049038: Change compile-time errors into dynamic errors in instance creation expression (Closed)

Created:
8 years, 2 months ago by regis
Modified:
8 years, 2 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change compile-time errors into dynamic errors in instance creation expression (issue 3085). Change compile-time errors into dynamic errors in static getter and setter calls (issues 3088, 3094). Fix a crash in flow graph builder for missing static getter (issue 4360). Add support in VM for NoSuchMethodError. Remove support in VM for StaticResolutionException. Add, remove, update related language tests. Triage related co19 tests. Committed: https://code.google.com/p/dart/source/detail?r=13208

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -337 lines) Patch
M runtime/lib/error.cc View 1 3 chunks +17 lines, -14 lines 0 comments Download
M runtime/lib/error.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M runtime/vm/ast.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/ast.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.h View 1 1 chunk +11 lines, -9 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +35 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 16 chunks +88 lines, -63 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 11 chunks +0 lines, -34 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 10 chunks +9 lines, -45 lines 0 comments Download
M tests/language/call_constructor_on_unresolvable_class_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language/call_nonexistent_constructor_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/class_literal_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/language/language.status View 1 11 chunks +9 lines, -40 lines 0 comments Download
M tests/language/language_dart2js.status View 1 4 chunks +2 lines, -9 lines 0 comments Download
M tests/language/named_parameters2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/named_parameters3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/named_parameters4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/setter_no_getter_call_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/setter_no_getter_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D tests/language/static_field3_negative_test.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
A + tests/language/static_field3_test.dart View 1 chunk +7 lines, -9 lines 0 comments Download
D tests/language/static_field3a_negative_test.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language/static_field4_negative_test.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language/static_field4a_negative_test.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
8 years, 2 months ago (2012-10-03 22:58:34 UTC) #1
srdjan
LGTM https://codereview.chromium.org/11049038/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/11049038/diff/1/runtime/vm/flow_graph_builder.cc#newcode2001 runtime/vm/flow_graph_builder.cc:2001: // a setter, so we throw a NoSuchMethodError. ...
8 years, 2 months ago (2012-10-03 23:28:03 UTC) #2
hausner
Nice. LGTM.
8 years, 2 months ago (2012-10-04 00:06:46 UTC) #3
regis
8 years, 2 months ago (2012-10-04 00:12:23 UTC) #4
Thank you gentlemen.

https://codereview.chromium.org/11049038/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/11049038/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.cc:2001: // a setter, so we throw a
NoSuchMethodError.
On 2012/10/03 23:28:03, srdjan wrote:
> The comment is not very clear.

I tried to improve it.

https://codereview.chromium.org/11049038/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11049038/diff/1/runtime/vm/parser.cc#newcode7359
runtime/vm/parser.cc:7359: // No field or explicit getter function, hrow a
NoSuchMethodError.
On 2012/10/03 23:28:03, srdjan wrote:
> s/hrow/throw/

Done.

Powered by Google App Engine
This is Rietveld 408576698