runtime/vm/dart_api_impl_test.cc - Issue 11049038: Change compile-time errors into dynamic errors in instance creation expression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 11049038: Change compile-time errors into dynamic errors in instance creation expression (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl_test.cc

===================================================================

--- runtime/vm/dart_api_impl_test.cc (revision 13204)

+++ runtime/vm/dart_api_impl_test.cc (working copy)

@@ -135,7 +135,7 @@

TEST_CASE(Dart_PropagateError) {

const char* kScriptChars =

"raiseCompileError() {\n"

- " return badIdent;\n"

+ " return missing_semicolon\n"

"}\n"

"\n"

"void throwException() {\n"

@@ -158,7 +158,7 @@

result = Dart_Invoke(lib, Dart_NewString("Func1"), 0, NULL);

EXPECT(Dart_IsError(result));

EXPECT(!Dart_ErrorHasException(result));

- EXPECT_SUBSTRING("badIdent", Dart_GetError(result));

+ EXPECT_SUBSTRING("semicolon expected", Dart_GetError(result));

result = Dart_Invoke(lib, Dart_NewString("Func2"), 0, NULL);

EXPECT(Dart_IsError(result));

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »