Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11049036: Remove spurious types from constructor args that use "this." (Closed)

Created:
8 years, 2 months ago by Jacob
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove spurious types from constructor args that use "this." The spurious types for args that have function types confuse Dart2Js and cause it to crash. http://code.google.com/p/dart/issues/detail?id=5619 BUG= Committed: https://code.google.com/p/dart/source/detail?r=13258

Patch Set 1 : Ready to review #

Total comments: 2

Patch Set 2 : Fixes for code review comment #

Patch Set 3 : ignore #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M lib/utf/utf16.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M lib/utf/utf32.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M lib/utf/utf8.dart View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/11049036/diff/2001/lib/utf/utf16.dart File lib/utf/utf16.dart (right): https://codereview.chromium.org/11049036/diff/2001/lib/utf/utf16.dart#newcode217 lib/utf/utf16.dart:217: final Function codeunitsProvider; I was thinking of maybe ...
8 years, 2 months ago (2012-10-04 00:09:11 UTC) #1
Siggi Cherem (dart-lang)
(btw, if you can, please edit this cl to change the description to something more ...
8 years, 2 months ago (2012-10-04 00:11:45 UTC) #2
Jacob
8 years, 2 months ago (2012-10-04 00:13:53 UTC) #3
Jacob
https://codereview.chromium.org/11049036/diff/2001/lib/utf/utf16.dart File lib/utf/utf16.dart (right): https://codereview.chromium.org/11049036/diff/2001/lib/utf/utf16.dart#newcode217 lib/utf/utf16.dart:217: final Function codeunitsProvider; Added a couple typedefs. The Utf16 ...
8 years, 2 months ago (2012-10-04 00:44:09 UTC) #4
Siggi Cherem (dart-lang)
lgtm, thanks!
8 years, 2 months ago (2012-10-04 01:25:36 UTC) #5
ahe
8 years, 2 months ago (2012-10-04 08:54:54 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698