Remove spurious types from constructor args that use "this."

lib/utf/utf16.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 /**
  * Decodes the UTF-16 bytes as an iterable. Thus, the consumer can only convert
  * as much of the input as needed. Determines the byte order from the BOM,
  * or uses big-endian as a default. This method always strips a leading BOM.
  * Set the [replacementCodepoint] to null to throw an ArgumentError
@@ skipping 196 matching lines @@
     return _codepointsToUtf16CodeUnits(str.charCodes());
   }
 }
 
 /**
  * Return type of [decodeUtf16AsIterable] and variants. The Iterable type
  * provides an iterator on demand and the iterator will only translate bytes
  * as requested by the user of the iterator. (Note: results are not cached.)
  */
 class IterableUtf16Decoder implements Iterable<int> {
   final Function codeunitsProvider;

[Siggi Cherem (dart-lang), 2012/10/04 00:09:11]

I was thinking of maybe adding a typedef for this field's type (to match what
was there before in the ctor)?

The other file didn't seem that have that precise signature, but maybe they both
should?

[Jacob, 2012/10/04 00:44:10]

Added a couple typedefs.  The Utf16 and Utf32 cases seem kinda inconsistent at
the moment but I haven't examined the code carefully enough to be sure.
On 2012/10/04 00:09:11, sigmund wrote:

   final int replacementCodepoint;
 
-  IterableUtf16Decoder._(_ListRangeIterator this.codeunitsProvider(),
-      int this.replacementCodepoint);
+  IterableUtf16Decoder._(this.codeunitsProvider, this.replacementCodepoint);
 
   Utf16CodeUnitDecoder iterator() =>
       new Utf16CodeUnitDecoder.fromListRangeIterator(codeunitsProvider(),
           replacementCodepoint);
 }
 
 /**
  * Convert UTF-16 encoded bytes to UTF-16 code units by grouping 1-2 bytes
  * to produce the code unit (0-(2^16)-1). Relies on BOM to determine
  * endian-ness, and defaults to BE.
  */
 class Utf16BytesToCodeUnitsDecoder implements _ListRangeIterator {
   final _ListRangeIterator utf16EncodedBytesIterator;
   final int replacementCodepoint;
 
   Utf16BytesToCodeUnitsDecoder._fromListRangeIterator(
-      _ListRangeIterator this.utf16EncodedBytesIterator,
-      int this.replacementCodepoint);
+      this.utf16EncodedBytesIterator, this.replacementCodepoint);
 
   factory Utf16BytesToCodeUnitsDecoder(List<int> utf16EncodedBytes, [
       int offset = 0, int length,
       int replacementCodepoint = UNICODE_REPLACEMENT_CHARACTER_CODEPOINT]) {
     if (length == null) {
       length = utf16EncodedBytes.length - offset;
     }
     if (hasUtf16beBom(utf16EncodedBytes, offset, length)) {
       return new Utf16beBytesToCodeUnitsDecoder(utf16EncodedBytes, offset + 2,
           length - 2, false, replacementCodepoint);
@@ skipping 93 matching lines @@
       skip();
     }
   }
 
   int decode() {
     int lo = utf16EncodedBytesIterator.next();
     int hi = utf16EncodedBytesIterator.next();
     return (hi << 8) + lo;
   }
 }