Issue 11043020: Add fast 64-bit bitwise negation to the IA32 optimizing compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11043020: Add fast 64-bit bitwise negation to the IA32 optimizing compiler. (Closed)

Created:
8 years, 2 months ago by Florian Schneider

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add fast 64-bit bitwise negation to the IA32 optimizing compiler. Committed: https://code.google.com/p/dart/source/detail?r=13221

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fixed bug in the optimizer that prevented optimization #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -14 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	5 chunks	+32 lines, -10 lines	1 comment	Download
M	runtime/vm/il_printer.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	3 chunks	+57 lines, -0 lines	0 comments	Download
	runtime/vm/intermediate_language.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+22 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

rebased, fixed deoptimization reasons for unboxing integer operations.

8 years, 2 months ago (2012-10-04 09:35:09 UTC) #2

Kevin Millikin (Google)

8 years, 2 months ago (2012-10-04 11:56:06 UTC) #3

lgtm

https://codereview.chromium.org/11043020/diff/10013/runtime/vm/flow_graph_opt...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11043020/diff/10013/runtime/vm/flow_graph_opt...
runtime/vm/flow_graph_optimizer.cc:2933: // TODO(kmillikin): Handle unary
operations.
TODO(fschneider) :)

Expand Messages | Collapse Messages