runtime/vm/disassembler_ia32.cc - Issue 11043020: Add fast 64-bit bitwise negation to the IA32 optimizing compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 11043020: Add fast 64-bit bitwise negation to the IA32 optimizing compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed bug in the optimizer that prevented optimization Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_ia32.cc

===================================================================

--- runtime/vm/disassembler_ia32.cc (revision 13214)

+++ runtime/vm/disassembler_ia32.cc (working copy)

@@ -1496,8 +1496,7 @@

PrintCPURegister(regop);

Print(",");

data += PrintRightXmmOperand(data);

- } else if (*data == 0x3A &&

- *(data+1) == 0x16) {

+ } else if (*data == 0x3A && *(data+1) == 0x16) {

Print("pextrd ");

data += 2;

int mod, regop, rm;

@@ -1510,6 +1509,14 @@

data += 2;

} else if (*data == 0x38) {

data += Packed660F38Instruction(data);

+ } else if (*data == 0xEF) {

+ int mod, regop, rm;

+ GetModRm(*(data+1), &mod, &regop, &rm);

+ Print("pxor ");

+ PrintXmmRegister(regop);

+ Print(",");

+ PrintXmmRegister(rm);

+ data += 2;

} else {

UNIMPLEMENTED();

}

« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')