Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to

Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to
noteOff.
Committed: https://code.google.com/p/dart/source/detail?r=13156

[blois, 2012-10-02 23:08:18]

https://codereview.chromium.org/11043013/diff/2001/lib/html/templates/html/da...
File lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate
(right):

https://codereview.chromium.org/11043013/diff/2001/lib/html/templates/html/da...
lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate:11:
grainDuration): this.noteOn(when, grainOffset, grainDuration);""";
I believe that we should be using the JS() syntax from now on.

Also, it should be sufficient to do !!this.start- I don't think we normally
validate the actual type.

[Emily Fortuna, 2012-10-02 23:37:05]

PTAL

https://codereview.chromium.org/11043013/diff/2001/lib/html/templates/html/da...
File lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate
(right):

https://codereview.chromium.org/11043013/diff/2001/lib/html/templates/html/da...
lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate:11:
grainDuration): this.noteOn(when, grainOffset, grainDuration);""";
On 2012/10/02 23:08:18, blois wrote:
> I believe that we should be using the JS() syntax from now on.
> 
> Also, it should be sufficient to do !!this.start- I don't think we normally
> validate the actual type.

Good point. Fixed up.

[blois, 2012-10-02 23:43:25]

https://codereview.chromium.org/11043013/diff/2003/tests/html/audiobuffersour...
File tests/html/audiobuffersourcenode_test.dart (right):

https://codereview.chromium.org/11043013/diff/2003/tests/html/audiobuffersour...
tests/html/audiobuffersourcenode_test.dart:12: AudioBufferSourceNode node =
ctx.createBufferSource();
I don't think this test works on all (many?) platforms- you're probably going to
need some updates to html.status.

[Emily Fortuna, 2012-10-02 23:59:43]

PTAL

https://codereview.chromium.org/11043013/diff/2003/tests/html/audiobuffersour...
File tests/html/audiobuffersourcenode_test.dart (right):

https://codereview.chromium.org/11043013/diff/2003/tests/html/audiobuffersour...
tests/html/audiobuffersourcenode_test.dart:12: AudioBufferSourceNode node =
ctx.createBufferSource();
On 2012/10/02 23:43:25, blois wrote:
> I don't think this test works on all (many?) platforms- you're probably going
to
> need some updates to html.status.

It works on Chrome and Safari 6, but I had forgotten to check Firefox. (and
Safari 5.2 probably isn't going to work either) Updated.

[blois, 2012-10-03 00:12:30]

lgtm