Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Issue 11043013: Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/html/scripts/systemhtml.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dart2js/html_dart2js.dart
===================================================================
--- lib/html/dart2js/html_dart2js.dart (revision 13149)
+++ lib/html/dart2js/html_dart2js.dart (working copy)
@@ -679,9 +679,30 @@
/** @domName AudioBufferSourceNode.stop */
void stop(num when);
}
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
class _AudioBufferSourceNodeImpl extends _AudioSourceNodeImpl implements AudioBufferSourceNode native "*AudioBufferSourceNode" {
+ // TODO(efortuna): Remove these methods when Chrome stable also uses start
+ // instead of noteOn.
+ void start(num when, [num grainOffset, num grainDuration]) {
+ if (JS('bool', '!!#.start', this)) {
+ JS('void', '#.start(#, #, #)', this, when, grainOffset, grainDuration);
+ } else {
+ JS('void', '#.noteOn(#, #, #)', this, when, grainOffset, grainDuration);
+ }
+ }
+
+ void stop(num when) {
+ if (JS('bool', '!!#.stop', this)) {
+ JS('void', '#.stop(#)', this, when);
+ } else {
+ JS('void', '#.noteOff(#)', this, when);
+ }
+ }
+
static const int FINISHED_STATE = 3;
static const int PLAYING_STATE = 2;
@@ -702,9 +723,6 @@
final int playbackState;
- void start(num when, [num grainOffset, num grainDuration]) native;
-
- void stop(num when) native;
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
« no previous file with comments | « no previous file | lib/html/scripts/systemhtml.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698