Issue 11036035: Fix JS native binding and documentation for interfaces with overridden name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11036035: Fix JS native binding and documentation for interfaces with overridden name. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
vsm, Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix JS native binding and documentation for interfaces with overridden name. R=vsm@google.com,sra@google.com,antonm@google.com BUG=5657 Committed: https://code.google.com/p/dart/source/detail?r=13296

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+303 lines, -303 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	16 chunks	+155 lines, -155 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	14 chunks	+146 lines, -146 lines	0 comments	Download
M	lib/html/scripts/idlnode.py	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm http://codereview.chromium.org/11036035/diff/1/lib/html/scripts/idlnode.py File lib/html/scripts/idlnode.py (right): http://codereview.chromium.org/11036035/diff/1/lib/html/scripts/idlnode.py#newcode383 lib/html/scripts/idlnode.py:383: self.doc_js_name = self.ext_attrs.get('InterfaceName', self.id) nit: self.j_b_n = self.d_j_n ...

8 years, 2 months ago (2012-10-05 11:45:22 UTC) #3

lgtm

Expand Messages | Collapse Messages