lib/html/scripts/idlnode.py - Issue 11036035: Fix JS native binding and documentation for interfaces with overridden name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/scripts/idlnode.py

Issue 11036035: Fix JS native binding and documentation for interfaces with overridden name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/scripts/idlnode.py

diff --git a/lib/html/scripts/idlnode.py b/lib/html/scripts/idlnode.py

index 78093679e9253b2625755284661ea8d55ba5a4b0..f152c9791a0733d7925146950e55a130c93f4a4c 100755

--- a/lib/html/scripts/idlnode.py

+++ b/lib/html/scripts/idlnode.py

@@ -379,8 +379,8 @@ class IDLInterface(IDLNode):

self._convert_annotations(ast)

self.parents = self._convert_all(ast, 'ParentInterface',

IDLParentInterface)

- self.javascript_binding_name = self.id

- self.doc_js_name = self.id

+ self.javascript_binding_name = self.ext_attrs.get('InterfaceName', self.id)

+ self.doc_js_name = self.ext_attrs.get('InterfaceName', self.id)

Anton Muhin 2012/10/05 11:45:22 nit: self.j_b_n = self.d_j_n = self.ext_attrs...

self.operations = self._convert_all(ast, 'Operation',

lambda ast: IDLOperation(ast, self.doc_js_name))

self.attributes = self._convert_all(ast, 'Attribute',

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »