Add in-process http server to the dart test scripts.

Add in-process http server to the dart test scripts.

Removed support for extra commands. Change pkg/intl test to use
builtin http server.

Fixed regression in test runner so the test script terminates when
passing in an unknown selector.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13217

[ahe, 2012-10-04 10:06:43]

LGTM, but I'll come by your desk and ask if you can walk me through the changes
to ProcessQueue.

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:1: #library('http_server');
Missing copyright.

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:448: List _append(list1,list2) =>
[]..addAll(list1)..addAll(list2);
Remove this.

[Mads Ager (google), 2012-10-04 10:21:51]

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:1: #library('http_server');
On 2012/10/04 10:06:43, ahe wrote:
> Missing copyright.

Done.

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:448: List _append(list1,list2) =>
[]..addAll(list1)..addAll(list2);
On 2012/10/04 10:06:43, ahe wrote:
> Remove this.

Thanks! Done.

[ricow1, 2012-10-04 10:28:05]

LGTM

https://codereview.chromium.org/11035027/diff/6001/pkg/intl/test/date_time_fo...
File pkg/intl/test/date_time_format_http_request_test.dart (right):

https://codereview.chromium.org/11035027/diff/6001/pkg/intl/test/date_time_fo...
pkg/intl/test/date_time_format_http_request_test.dart:10: // TODO(alanknight):
It would be nice if there were a more general facility
replace this comment?

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:11: _httpServer.listen(host, port);
shouldn't we set the error handler before calling listen?

[Søren Gjesse, 2012-10-04 10:34:24]

lgtm

https://codereview.chromium.org/11035027/diff/6002/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:29: if (exists) {
How about adding a Content-Type based on the file extension, like in
https://codereview.chromium.org/10966020/diff/7002/utils/testrunner/http_serv...

We should probably have this mapping available somewhere in dart:io at some
point.

[Mads Ager (google), 2012-10-04 10:41:42]

https://codereview.chromium.org/11035027/diff/6001/pkg/intl/test/date_time_fo...
File pkg/intl/test/date_time_format_http_request_test.dart (right):

https://codereview.chromium.org/11035027/diff/6001/pkg/intl/test/date_time_fo...
pkg/intl/test/date_time_format_http_request_test.dart:10: // TODO(alanknight):
It would be nice if there were a more general facility
On 2012/10/04 10:28:06, ricow1 wrote:
> replace this comment?

Heh, thanks Rico, good catch.

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6001/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:11: _httpServer.listen(host, port);
On 2012/10/04 10:28:06, ricow1 wrote:
> shouldn't we set the error handler before calling listen?

I have moved it. It doesn't really matter at this point. If the listen fails I
don't think it is actually propagated the the server. But it probably should be
so registering the error handler first is the right thing to do. Thanks!

https://codereview.chromium.org/11035027/diff/6002/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11035027/diff/6002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:29: if (exists) {
On 2012/10/04 10:34:24, Søren Gjesse wrote:
> How about adding a Content-Type based on the file extension, like in
>
https://codereview.chromium.org/10966020/diff/7002/utils/testrunner/http_serv...
> 
> We should probably have this mapping available somewhere in dart:io at some
> point.

Yeah, let's add that when we need it. I would like to keep the code as simple as
possible.

[Alan Knight, 2012-10-04 18:04:54]

lgtm

[Ivan Posva, 2012-10-30 21:27:04]

I filed bug 6410 to track the resolution of this issue.

-Ivan

https://codereview.chromium.org/11035027/diff/12001/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/11035027/diff/12001/tools/test.dart#newcode130
tools/test.dart:130: startHttpServer('127.0.0.1', 9876);
How is this supposed to work when two people on the same machine are running
tests or when a user attempts to run tests in two clients concurrently?

[Mads Ager (google), 2012-10-31 06:40:52]

On 2012/10/30 21:27:04, Ivan Posva wrote:
> I filed bug 6410 to track the resolution of this issue.
> 
> -Ivan
> 
> https://codereview.chromium.org/11035027/diff/12001/tools/test.dart
> File tools/test.dart (right):
> 
> https://codereview.chromium.org/11035027/diff/12001/tools/test.dart#newcode130
> tools/test.dart:130: startHttpServer('127.0.0.1', 9876);
> How is this supposed to work when two people on the same machine are running
> tests or when a user attempts to run tests in two clients concurrently?

It is not.