Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2594)

Unified Diff: pkg/intl/test/date_time_format_http_request_test.dart

Issue 11035027: Add in-process http server to the dart test scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address more comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/intl/test/start_web_server.dart » ('j') | tools/test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/test/date_time_format_http_request_test.dart
diff --git a/pkg/intl/test/date_time_format_http_request_test.dart b/pkg/intl/test/date_time_format_http_request_test.dart
index 0265861cd9e70eaed9e4c2a62a4d30d3fdd91776..be7c93ee83259ca5b1b1156aa88c2461d2460367 100644
--- a/pkg/intl/test/date_time_format_http_request_test.dart
+++ b/pkg/intl/test/date_time_format_http_request_test.dart
@@ -7,15 +7,6 @@
* to a server.
*/
-// TODO(alanknight): It would be nice if there were a more general facility
-// than this and it could be replaced, possibly the things Graham is working on.
-// The following magical comments will cause the test code run via test.py
-// to add an extra command starting up a web server that will serve the
-// files we are looking for. "dart" will be replaced by the current dart
-// VM, and in arguments, $dartDir will be replaced by the current Dart
-// root directory.
-// ExtraCommand=dart
-// ExtraCommandArgs=$dartDir/pkg/intl/test/start_web_server.dart
#library('date_time_format_http_request_test');
#import('../lib/intl.dart');
@@ -24,7 +15,7 @@
#import('dart:html');
#import('../../../pkg/unittest/unittest.dart');
-var url = "http://localhost:8000/dates/";
+var url = "http://localhost:9876/pkg/intl/lib/src/data/dates/";
main() {
// Initialize one locale just so we know what the list is.
@@ -45,4 +36,4 @@ void shutDown() {
// The tiny web server knows to use this request as a cue to terminate.
var source = '${url}terminate';
var request = new HttpRequest.get(source, (_) {});
-}
+}
« no previous file with comments | « no previous file | pkg/intl/test/start_web_server.dart » ('j') | tools/test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698