Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11033044: Fix opening of print dialog on IE when testing dart2js (Closed)

Created:
8 years, 2 months ago by ricow1
Modified:
8 years, 2 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix opening of print dialog on IE when testing dart2js Committed: https://code.google.com/p/dart/source/detail?r=13273

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/compiler/implementation/lib/js_helper.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
8 years, 2 months ago (2012-10-05 06:35:41 UTC) #1
ahe
http://codereview.chromium.org/11033044/diff/1/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): http://codereview.chromium.org/11033044/diff/1/lib/compiler/implementation/lib/js_helper.dart#newcode399 lib/compiler/implementation/lib/js_helper.dart:399: JS('void', "throw 'Unable to print message: ' + String(#)", ...
8 years, 2 months ago (2012-10-05 06:40:22 UTC) #2
ricow1
http://codereview.chromium.org/11033044/diff/1/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): http://codereview.chromium.org/11033044/diff/1/lib/compiler/implementation/lib/js_helper.dart#newcode399 lib/compiler/implementation/lib/js_helper.dart:399: JS('void', "throw 'Unable to print message: ' + String(#)", ...
8 years, 2 months ago (2012-10-05 06:45:16 UTC) #3
ahe
8 years, 2 months ago (2012-10-05 06:46:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698