lib/compiler/implementation/lib/js_helper.dart - Issue 11033044: Fix opening of print dialog on IE when testing dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 11033044: Fix opening of print dialog on IE when testing dart2js (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/lib/js_helper.dart

===================================================================

--- lib/compiler/implementation/lib/js_helper.dart (revision 13271)

+++ lib/compiler/implementation/lib/js_helper.dart (working copy)

@@ -378,8 +378,11 @@

}

// Inside browser.

- if (JS('bool', r'typeof console == "object"')) {

- JS('void', r'console.log(#)', string);

+ if (JS('bool', r'typeof window == "object"')) {

+ // On IE, the console is only defined if dev tools is open.

+ if (JS('bool', r'typeof console == "object"')) {

+ JS('void', r'console.log(#)', string);

+ }

return;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »