Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 11032011: Intrinsify Float32Array_setIndexed on IA32 and X64 (Closed)

Created:
8 years, 2 months ago by Cutch
Modified:
8 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Intrinsify Float32Array_setIndexed on IA32 and X64 Committed: https://code.google.com/p/dart/source/detail?r=13093

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix register usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -20 lines) Patch
M runtime/vm/intrinsifier_ia32.cc View 1 3 chunks +38 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 9 chunks +55 lines, -19 lines 0 comments Download
M tests/standalone/float_array_test.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
Also, please add a test https://codereview.chromium.org/11032011/diff/1/runtime/vm/intrinsifier_ia32.cc File runtime/vm/intrinsifier_ia32.cc (right): https://codereview.chromium.org/11032011/diff/1/runtime/vm/intrinsifier_ia32.cc#newcode613 runtime/vm/intrinsifier_ia32.cc:613: __ movl(EDX, Address(ESP, + ...
8 years, 2 months ago (2012-10-01 22:59:40 UTC) #1
srdjan
8 years, 2 months ago (2012-10-01 23:39:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698