Intrinsify Float32Array_setIndexed on IA32 and X64

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 414 matching lines @@
   __ movq(RBX, Address(RSP, + 1 * kWordSize));  // Index.
   __ testq(RBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, fall_through, Assembler::kNearJump);  // Non-smi index.
   // Range check.
   __ cmpq(RBX, FieldAddress(RAX, ByteArray::length_offset()));
   // Runtime throws exception.
   __ j(ABOVE_EQUAL, fall_through, Assembler::kNearJump);
 }
 
 
+// Operates in the same manner as TestByteArrayIndex.
+// This should be used only for setIndexed intrinsics.
+static void TestByteArraySetIndex(Assembler* assembler, Label* fall_through) {
+  __ movq(RAX, Address(RSP, + 3 * kWordSize));  // Array.
+  __ movq(RBX, Address(RSP, + 2 * kWordSize));  // Index.

[srdjan, 2012/10/01 22:59:40]

You cannot use RBX if there is a slow path. This is also valid for code above.
(see comment at head of file: RBX, R10 can be used only if there is no
fall-through)

+  __ testq(RBX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check.
+  __ cmpq(RBX, FieldAddress(RAX, ByteArray::length_offset()));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, fall_through, Assembler::kNearJump);
+}
+
+
 bool Intrinsifier::Int8Array_getIndexed(Assembler* assembler) {
   Label fall_through;
   TestByteArrayIndex(assembler, &fall_through);
   __ SmiUntag(RBX);
   __ movsxb(RAX, FieldAddress(RAX,
                               RBX,
                               TIMES_1,
                               Int8Array::data_offset()));
   __ SmiTag(RAX);
   __ ret();
@@ skipping 65 matching lines @@
   __ movl(RAX, FieldAddress(RAX,
                             RBX,
                             TIMES_2,
                             Uint32Array::data_offset()));
   __ SmiTag(RAX);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
+
 bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
   Label fall_through;
   TestByteArrayIndex(assembler, &fall_through);
   // After TestByteArrayIndex:
   // * RAX has the base address of the byte array.
   // * RBX has the index into the array.
   // RBX contains the SMI index which is shifted left by 1.
   // This shift means we only multiply the index by 2 not 4 (sizeof float).
   // Load single precision float into XMM7.
   __ movss(XMM7, FieldAddress(RAX, RBX, TIMES_2,
                               Float32Array::data_offset()));
   // Convert into a double precision float.
   __ cvtss2sd(XMM7, XMM7);
   // Allocate a double instance.
   const Class& double_class = Class::Handle(
                           Isolate::Current()->object_store()->double_class());
   AssemblerMacros::TryAllocate(assembler,
                                double_class,
                                &fall_through,
                                Assembler::kNearJump, RAX);
   // Store XMM7 into double instance.
   __ movsd(FieldAddress(RAX, Double::value_offset()), XMM7);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
+
 bool Intrinsifier::Float32Array_setIndexed(Assembler* assembler) {
-    return false;
+  Label fall_through;
+  TestByteArraySetIndex(assembler, &fall_through);
+  // After TestByteArraySetIndex:
+  // * RAX has the base address of the byte array.
+  // * RBX has the index into the array.
+  // RBX contains the SMI index which is shifted by 1.
+  // This shift means we only multiply the index by 2 not 4 (sizeof float).
+  __ movq(RDX, Address(RSP, + 1 * kWordSize));  // Value.
+  // If RDX is not an instance of double, jump to fall through.
+  __ CompareClassId(RDX, kDoubleCid);
+  __ j(NOT_EQUAL, &fall_through);
+  // Load double value into XMM7.
+  __ movsd(XMM7, FieldAddress(RDX, Double::value_offset()));
+  // Convert from double precision float to single precision float.
+  __ cvtsd2ss(XMM7, XMM7);
+  // Store into array.
+  __ movss(FieldAddress(RAX, RBX, TIMES_2, Float32Array::data_offset()), XMM7);
+  // End fast path.
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
 }
 
 
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in RAX.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ movq(RAX, Address(RSP, + 1 * kWordSize));
   __ movq(RCX, Address(RSP, + 2 * kWordSize));
   __ orq(RCX, RAX);
   __ testq(RCX, Immediate(kSmiTagMask));
@@ skipping 857 matching lines @@
   __ LoadObject(RAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64