Issue 11031068: Do not GVN HLocalGet. If the local is final, the GVN thinks it can loop hoist accesses to it (which…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11031068: Do not GVN HLocalGet. If the local is final, the GVN thinks it can loop hoist accesses to it (which… (Closed)

Created:
8 years, 2 months ago by ngeoffray

Modified:
8 years, 2 months ago

Reviewers:
Søren Gjesse, kasperl

CC:
reviews_dartlang.org, Emily Fortuna

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not GVN HLocalGet. If the local is final, the GVN thinks it can loop hoist accesses to it (which it can't because the variable may have not been initialized). Committed: https://code.google.com/p/dart/source/detail?r=13280

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	lib/compiler/implementation/ssa/nodes.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	A	tests/language/final_used_in_try_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

This fixes the regression Emily was seeing on the Dromaeo benchmark.

8 years, 2 months ago (2012-10-05 10:28:35 UTC) #1

LGTM.

Expand Messages | Collapse Messages