Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 11031068: Do not GVN HLocalGet. If the local is final, the GVN thinks it can loop hoist accesses to it (which… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/final_used_in_try_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 13220)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1557,6 +1557,12 @@
accept(HVisitor visitor) => visitor.visitLocalGet(this);
HLocalValue get local => inputs[0];
+
+ void prepareGvn(HTypeMap types) {
+ // No need to use GVN for a [HLocalGet], it is just a local
+ // access.
+ clearAllSideEffects();
+ }
}
class HLocalSet extends HFieldSet {
« no previous file with comments | « no previous file | tests/language/final_used_in_try_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698