Issue 11029002: Revert r13022 (revert inlining of methods with control flow), Review URL: https://codereview.chromi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11029002: Revert r13022 (revert inlining of methods with control flow), Review URL: https://codereview.chromi… (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, Kevin Millikin (Google), zerny-google

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Revert r13022 (revert inlining of methods with control flow), Review URL: https://codereview.chromium.org//10979078; disable inlining of methods with control-flow so that we do not run out of heap space. Committed: https://code.google.com/p/dart/source/detail?r=13081

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+313 lines, -77 lines)			Patch
M	runtime/vm/flow_graph.h	View	1 2 3 4	4 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 2 3 4	5 chunks	+156 lines, -22 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4	7 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2 3 4	7 chunks	+133 lines, -48 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4	2 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/language/deopt_inlined_function_lazy_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/language/deopt_inlined_function_test.dart	View	1 2 3 4	2 chunks	+2 lines, -3 lines	0 comments	Download
A +	tests/language/inline_effect_context_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/language/inline_test_context_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/language/inline_value_context_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM