Issue 10979078: Revert several inlining related changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979078: Revert several inlining related changes. (Closed)

Created:
8 years, 2 months ago by Kevin Millikin (Google)

Modified:
8 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert several inlining related changes. Revert svn revisions r12990, r12991, r12995, and r13000. Increased inlining leads to excessive code growth, preventing dart2js to run in checked mode. The changes will be relanded when we can come up with improved size thresholds. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13022

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -468 lines)			Patch
M	runtime/vm/flow_graph.h	View	4 chunks	+1 line, -10 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	8 chunks	+27 lines, -166 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	6 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	8 chunks	+59 lines, -132 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/language/deopt_inlined_function_lazy_test.dart	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	tests/language/deopt_inlined_function_test.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
D	tests/language/inline_effect_context_test.dart	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	tests/language/inline_test_context_test.dart	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	tests/language/inline_value_context_test.dart	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 2 months ago (2012-09-28 15:11:26 UTC) #3

On 2012/09/28 14:13:08, ngeoffray wrote:
> LGTM, thanks Kevin

Instead of reverting, why didn't you just disable inlining with control-flow?

Expand Messages | Collapse Messages