Make sure to wrap all callbacks with expectAsync in tests

Make sure to wrap all callbacks with expectAsync in tests
Committed: https://code.google.com/p/dart/source/detail?r=13124

[Alan Knight, 2012-10-02 00:14:54]

Some tests weren't wrapping callbacks in expectAsync<N> calls, which appears to
mean the code in those callbacks might be not be checked before the test exits
and believes it's passed, depending on timing. That would be bad.

[Emily Fortuna, 2012-10-02 00:42:55]

glad this is fixed up. lgtm with comments

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_file_test_stub.dart (right):

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_file_test_stub.dart:21: test('Run everything', ()
{
can we make this test name more descriptive? like "running all
date_time_formatting" or something

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_file_test_stub.dart:33: expectAsync1((results) =>
runDateTests(getSubset())));});
I'd add a line break after the semicolon

[Alan Knight, 2012-10-02 20:12:21]

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_file_test_stub.dart (right):

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_file_test_stub.dart:21: test('Run everything', ()
{
On 2012/10/02 00:42:55, Emily Fortuna wrote:
> can we make this test name more descriptive? like "running all
> date_time_formatting" or something

Done.

https://codereview.chromium.org/11028010/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_file_test_stub.dart:33: expectAsync1((results) =>
runDateTests(getSubset())));});
On 2012/10/02 00:42:55, Emily Fortuna wrote:
> I'd add a line break after the semicolon

Done.