Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: pkg/intl/test/date_time_format_file_test_stub.dart

Issue 11028010: Make sure to wrap all callbacks with expectAsync in tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/intl/lib/intl_browser.dart ('k') | pkg/intl/test/date_time_format_http_request_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Tests date formatting and parsing using locale data read from the 6 * Tests date formatting and parsing using locale data read from the
7 * local file system. 7 * local file system.
8 */ 8 */
9 9
10 #library('date_time_format_file_test'); 10 #library('date_time_format_file_test');
11 11
12 #import('../lib/date_format.dart'); 12 #import('../lib/date_format.dart');
13 #import('../lib/date_symbol_data_file.dart'); 13 #import('../lib/date_symbol_data_file.dart');
14 #import('dart:io'); 14 #import('dart:io');
15 #import('date_time_format_test_core.dart'); 15 #import('date_time_format_test_core.dart');
16 #import('data_directory.dart'); 16 #import('data_directory.dart');
17 #import('../../../pkg/unittest/unittest.dart');
17 18
18 runWith([Function getSubset]) { 19 runWith([Function getSubset]) {
19 // Initialize one locale just so we know what the list is. 20 // Initialize one locale just so we know what the list is.
20 initializeDateFormatting("en_US", dataDirectory).then( 21 test('Run everything', () {
Emily Fortuna 2012/10/02 00:42:55 can we make this test name more descriptive? like
Alan Knight 2012/10/02 20:12:21 Done.
21 (_) => runEverything(getSubset)); 22 initializeDateFormatting("en_US", dataDirectory).then(
23 expectAsync1((_) => runEverything(getSubset)));
24 });
22 } 25 }
23 26
24 void runEverything(Function getSubset) { 27 void runEverything(Function getSubset) {
25 // Initialize all locales and wait for them to finish before running tests. 28 // Initialize all locales and wait for them to finish before running tests.
26 var futures = DateFormat.allLocalesWithSymbols().map( 29 var futures = DateFormat.allLocalesWithSymbols().map(
27 (locale) => initializeDateFormatting(locale, dataDirectory)); 30 (locale) => initializeDateFormatting(locale, dataDirectory));
28 Futures.wait(futures).then((results) => runDateTests(getSubset())); 31 test('Running things', () {
32 Futures.wait(futures).then(
33 expectAsync1((results) => runDateTests(getSubset())));});
Emily Fortuna 2012/10/02 00:42:55 I'd add a line break after the semicolon
Alan Knight 2012/10/02 20:12:21 Done.
29 } 34 }
OLDNEW
« no previous file with comments | « pkg/intl/lib/intl_browser.dart ('k') | pkg/intl/test/date_time_format_http_request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698