Issue 110223007: Handle failures to AcceptEx calls on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110223007: Handle failures to AcceptEx calls on Windows (Closed)

Created:
7 years ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle failures to AcceptEx calls on Windows R=ajohnsen@google.com BUG=http://dartbug.com/11165 Committed: https://code.google.com/p/dart/source/detail?r=31265

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	runtime/bin/eventhandler_win.cc	View		3 chunks	+8 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/110223007/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/110223007/diff/1/runtime/bin/eventhandler_win.cc#newcode977 runtime/bin/eventhandler_win.cc:977: if (!accept_success) { Move issue-accept into if and ...

7 years ago (2013-12-18 16:24:32 UTC) #2

Søren Gjesse

Committed patchset #1 manually as r31265 (presubmit successful).

7 years ago (2013-12-19 12:41:44 UTC) #3

Søren Gjesse

6 years, 11 months ago (2014-01-02 08:37:33 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/110223007/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/110223007/diff/1/runtime/bin/eventhandler_win...
runtime/bin/eventhandler_win.cc:977: if (!accept_success) {
On 2013/12/18 16:24:33, Anders Johnsen wrote:
> Move issue-accept into if and remove the boolean, and use break in if?

Done.

Expand Messages | Collapse Messages