Handle failures to AcceptEx calls on Windows

runtime/bin/eventhandler_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/eventhandler.h"
 
 #include <winsock2.h>  // NOLINT
@@ skipping 411 matching lines @@
   if (status == SOCKET_ERROR) {
     Log::PrintErr("Error WSAIoctl failed: %d\n", WSAGetLastError());
     return false;
   }
   return true;
 }
 
 
 bool ListenSocket::IssueAccept() {
   ScopedLock lock(this);
-
   // For AcceptEx there needs to be buffer storage for address
   // information for two addresses (local and remote address). The
   // AcceptEx documentation says: "This value must be at least 16
   // bytes more than the maximum address length for the transport
   // protocol in use."
   static const int kAcceptExAddressAdditionalBytes = 16;
   static const int kAcceptExAddressStorageSize =
       sizeof(SOCKADDR_STORAGE) + kAcceptExAddressAdditionalBytes;
   OverlappedBuffer* buffer =
       OverlappedBuffer::AllocateAcceptBuffer(2 * kAcceptExAddressStorageSize);
   DWORD received;
   BOOL ok;
   ok = AcceptEx_(socket(),
                  buffer->client(),
                  buffer->GetBufferStart(),
                  0,  // For now don't receive data with accept.
                  kAcceptExAddressStorageSize,
                  kAcceptExAddressStorageSize,
                  &received,
                  buffer->GetCleanOverlapped());
   if (!ok) {
     if (WSAGetLastError() != WSA_IO_PENDING) {
-      Log::PrintErr("AcceptEx failed: %d\n", WSAGetLastError());
+      int error = WSAGetLastError();
       closesocket(buffer->client());
       OverlappedBuffer::DisposeBuffer(buffer);
+      WSASetLastError(error);
       return false;
     }
   }
 
   pending_accept_count_++;
 
   return true;
 }
 
 
@@ skipping 496 matching lines @@
 
       // If incoming connections are requested make sure to post already
       // accepted connections.
       if ((msg->data & (1 << kInEvent)) != 0) {
         if (listen_socket->CanAccept()) {
           int event_mask = (1 << kInEvent);
           handle->set_mask(handle->mask() & ~event_mask);
           DartUtils::PostInt32(handle->port(), event_mask);
         }
         // Always keep 5 outstanding accepts going, to enhance performance.
-        while (listen_socket->pending_accept_count() < 5) {
-          listen_socket->IssueAccept();
+        bool accept_success = true;
+        while (listen_socket->pending_accept_count() < 5 && accept_success) {
+          accept_success = listen_socket->IssueAccept();
+          if (!accept_success) {

[Anders Johnsen, 2013/12/18 16:24:33]

Move issue-accept into if and remove the boolean, and use break in if?

[Søren Gjesse, 2014/01/02 08:37:33]

Done.

+            HandleError(listen_socket);
+          }
         }
       }
 
       if ((msg->data & (1 << kCloseCommand)) != 0) {
         listen_socket->Close();
       }
     } else {
       handle->EnsureInitialized(this);
 
       Handle::ScopedLock lock(handle);
@@ skipping 317 matching lines @@
 
 
 void EventHandlerImplementation::Shutdown() {
   SendData(kShutdownId, 0, 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)