Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 11018014: Change run_vm_tests to take the VM arguments before the test name so (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
Reviewers:
ricow1, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change run_vm_tests to take the VM arguments before the test name so it acts more like the standalone VM. That way the test scripts can uniformly pass extra arguments to the cctest runner and to the VM itself. The use case for this is that it is nice to be able to add extra vm flags to all tests using the --special-commands flag for the test runner: ./tools/test.py --special-commands='time @ --vm-flag' This will turn cc tests into: time run_vm_tests --vm-flag Selector and VM tests into: time dart --vm-flag my_test.dart R=ricow@google.com,asiva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13067

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M runtime/bin/run_vm_tests.cc View 1 2 chunks +12 lines, -10 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-10-01 13:32:47 UTC) #1
ricow1
LGTM http://codereview.chromium.org/11018014/diff/1/runtime/bin/run_vm_tests.cc File runtime/bin/run_vm_tests.cc (right): http://codereview.chromium.org/11018014/diff/1/runtime/bin/run_vm_tests.cc#newcode88 runtime/bin/run_vm_tests.cc:88: fprintf(stderr, "run_vm_tests <test name> [vm-flags ...]\n"); we should ...
8 years, 2 months ago (2012-10-01 13:50:28 UTC) #2
Mads Ager (google)
8 years, 2 months ago (2012-10-01 14:03:38 UTC) #3
http://codereview.chromium.org/11018014/diff/1/runtime/bin/run_vm_tests.cc
File runtime/bin/run_vm_tests.cc (right):

http://codereview.chromium.org/11018014/diff/1/runtime/bin/run_vm_tests.cc#ne...
runtime/bin/run_vm_tests.cc:88: fprintf(stderr, "run_vm_tests  <test name>
[vm-flags ...]\n");
On 2012/10/01 13:50:28, ricow1 wrote:
> we should update these to reflect the new structure

Done.

http://codereview.chromium.org/11018014/diff/1/runtime/bin/run_vm_tests.cc#ne...
runtime/bin/run_vm_tests.cc:103: } else if (argc == 2) {
On 2012/10/01 13:50:28, ricow1 wrote:
> I think we may need to update the functionality in here as well. Additionally,
> if we have exactly one vm flag and the testname we will hit the else clause in
> the button of this clause and _not_ get the flag passed on the the vm (i.e.,
we
> ignore it)

This is the argc == 2 case where argv[0] is the executable and there is only one
more argument argv[1] which is either one of these flags or a run_filter. So no
update is needed here.

Powered by Google App Engine
This is Rietveld 408576698