Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11018014: Change run_vm_tests to take the VM arguments before the test name so (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 var expectations = testExpectations.expectations( 137 var expectations = testExpectations.expectations(
138 '$testPrefix$testName'); 138 '$testPrefix$testName');
139 139
140 if (configuration["report"]) { 140 if (configuration["report"]) {
141 SummaryReport.add(expectations); 141 SummaryReport.add(expectations);
142 } 142 }
143 143
144 if (expectations.contains(SKIP)) return; 144 if (expectations.contains(SKIP)) return;
145 145
146 // The cc test runner takes options after the name of the test 146 var args = TestUtils.standardOptions(configuration);
147 // to run. 147 args.add(testName);
148 var args = [testName];
149 args.addAll(TestUtils.standardOptions(configuration));
150 148
151 doTest(new TestCase(constructedName, 149 doTest(new TestCase(constructedName,
152 [new Command(runnerPath, args)], 150 [new Command(runnerPath, args)],
153 configuration, 151 configuration,
154 completeHandler, 152 completeHandler,
155 expectations)); 153 expectations));
156 } 154 }
157 } 155 }
158 156
159 void forEachTest(TestCaseEvent onTest, Map testCache, [VoidFunction onDone]) { 157 void forEachTest(TestCaseEvent onTest, Map testCache, [VoidFunction onDone]) {
(...skipping 1334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1494 * $noCrash tests are expected to be flaky but not crash 1492 * $noCrash tests are expected to be flaky but not crash
1495 * $pass tests are expected to pass 1493 * $pass tests are expected to pass
1496 * $failOk tests are expected to fail that we won't fix 1494 * $failOk tests are expected to fail that we won't fix
1497 * $fail tests are expected to fail that we should fix 1495 * $fail tests are expected to fail that we should fix
1498 * $crash tests are expected to crash that we should fix 1496 * $crash tests are expected to crash that we should fix
1499 * $timeout tests are allowed to timeout 1497 * $timeout tests are allowed to timeout
1500 """; 1498 """;
1501 print(report); 1499 print(report);
1502 } 1500 }
1503 } 1501 }
OLDNEW
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698