Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 11017022: Revert r13286 "Fix issues with test.dart that appeared on Mac." (Closed)

Created:
8 years, 2 months ago by Emily Fortuna
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org, ricow1, ahe
Visibility:
Public.

Description

Add back in "graceful shutdown code" for Windows, because the fix for dartbug.com/1756 doesn't fix Windows. Also revert my change in r13368 to find the source of this problem. Committed: https://code.google.com/p/dart/source/detail?r=13379

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M tools/testing/dart/test_progress.dart View 1 3 chunks +3 lines, -5 lines 3 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +13 lines, -1 line 1 comment Download

Messages

Total messages: 8 (0 generated)
Emily Fortuna
The addition of Mads's CL (http://code.google.com/p/dart/source/detail?r=13217) is causing the Windows bots to hang. I suspect ...
8 years, 2 months ago (2012-10-08 21:14:05 UTC) #1
Emily Fortuna
Some additional information: I logged in to the bot and made this change locally on ...
8 years, 2 months ago (2012-10-08 21:16:14 UTC) #2
gram
This looks okay to me, but I am concerned that this is going to fix ...
8 years, 2 months ago (2012-10-08 22:02:43 UTC) #3
Emily Fortuna
PTAL -- I'm not making any changes except for the "graceful shutdown" code since it ...
8 years, 2 months ago (2012-10-08 22:24:28 UTC) #4
gram
https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_progress.dart#newcode89 tools/testing/dart/test_progress.dart:89: if (_failedTests > 0) exit(1); Did you intend to ...
8 years, 2 months ago (2012-10-08 22:34:08 UTC) #5
Emily Fortuna
https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_progress.dart#newcode89 tools/testing/dart/test_progress.dart:89: if (_failedTests > 0) exit(1); On 2012/10/08 22:34:08, gram ...
8 years, 2 months ago (2012-10-08 22:37:23 UTC) #6
gram
lgtm
8 years, 2 months ago (2012-10-08 22:41:19 UTC) #7
Mads Ager (google)
8 years, 2 months ago (2012-10-09 06:16:56 UTC) #8
https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_ru...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/11017022/diff/7001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:765: new Timer(shutdownMillisecs, (e) { if
(!closed) _process.kill(); });
Please don't do this. If you add a 30 sec timeout the test script will hang for
30 seconds even when the processes die. Instead, if this is really needed on
Windows, set up a timer that you cancel when the process terminates.

Powered by Google App Engine
This is Rietveld 408576698