Chromium Code Reviews| Index: tools/testing/dart/test_progress.dart |
| =================================================================== |
| --- tools/testing/dart/test_progress.dart (revision 13378) |
| +++ tools/testing/dart/test_progress.dart (working copy) |
| @@ -86,7 +86,7 @@ |
| _printTimingInformation(); |
| stdout.close(); |
| stderr.close(); |
| - exit(_failedTests > 0 ? 1 : 0); |
| + if (_failedTests > 0) exit(1); |
|
gram
2012/10/08 22:34:08
Did you intend to make this change? It seems the o
Emily Fortuna
2012/10/08 22:37:23
Yes, this was intentional. As mentioned in the com
|
| } |
| void _printStartProgress(TestCase test) {} |
| @@ -220,9 +220,7 @@ |
| void _printStartProgress(TestCase test) { } |
| void _printDoneProgress(TestCase test) { } |
| void allTestsKnown() { } |
| - void allDone() { |
| - exit(0); |
| - } |
| + void allDone() { } |
| } |
| abstract class CompactIndicator extends ProgressIndicator { |
| @@ -240,7 +238,7 @@ |
| } |
| stdout.close(); |
| stderr.close(); |
| - exit(_failedTests > 0 ? 1 : 0); |
| + if (_failedTests > 0) exit(1); |
|
gram
2012/10/08 22:34:08
Ditto
|
| } |
| void allTestsKnown() { |