Issue 11009006: Enable Float32Array_getIndexed on X64 now that cvtss2sd is implemented

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11009006: Enable Float32Array_getIndexed on X64 now that cvtss2sd is implemented (Closed)

Created:
8 years, 2 months ago by WRONG ACCOUNT

Modified:
8 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable Float32Array_getIndexed on X64 now that cvtss2sd is implemented Merge remote-tracking branch 'git-svn' Implement cvtss2sd and cvtsd2ss on X64 Committed: https://code.google.com/p/dart/source/detail?r=13077

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing review feedback #

Patch Set 3 : Merged this morning #

Total comments: 1

Patch Set 4 : Whitespace #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
M	runtime/vm/assembler_x64.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2 3	2 chunks	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11009006/diff/1/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/11009006/diff/1/runtime/vm/assembler_x64.cc#newcode674 runtime/vm/assembler_x64.cc:674: AssemblerBuffer::EnsureCapacity ensured(&buffer_); add asserts for dst, src <= ...

8 years, 2 months ago (2012-09-29 00:19:57 UTC) #1

srdjan

8 years, 2 months ago (2012-10-01 17:35:12 UTC) #2

LGTM

https://codereview.chromium.org/11009006/diff/8001/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/11009006/diff/8001/runtime/vm/assembler_x64.c...
runtime/vm/assembler_x64.cc:672: 
Two lines between functions

Expand Messages | Collapse Messages