Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 11009006: Enable Float32Array_getIndexed on X64 now that cvtss2sd is implemented (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Whitespace Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_x64.cc
diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc
index fce55dadd96b3300ab147c49bac9b8c74557bf50..03f42778c6f31dcfece67b6cb2d4df65dfc949b0 100644
--- a/runtime/vm/intrinsifier_x64.cc
+++ b/runtime/vm/intrinsifier_x64.cc
@@ -518,8 +518,7 @@ bool Intrinsifier::Uint32Array_getIndexed(Assembler* assembler) {
}
bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
- // Temporary fix until cvtss2sd implemented.
- /*Label fall_through;
+ Label fall_through;
TestByteArrayIndex(assembler, &fall_through);
// After TestByteArrayIndex:
// * RAX has the base address of the byte array.
@@ -541,7 +540,7 @@ bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
// Store XMM7 into double instance.
__ movsd(FieldAddress(RAX, Double::value_offset()), XMM7);
__ ret();
- __ Bind(&fall_through); */
+ __ Bind(&fall_through);
return false;
}
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698