Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1100873003: Avoid checking Uint8List for non-Latin-1 characters. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Avoid checking Uint8List for non-Latin-1 characters. Optimize checking code as well. Remove some unused code. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M sdk/lib/convert/ascii.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/convert/chunked_conversion.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M sdk/lib/convert/latin1.dart View 2 chunks +31 lines, -9 lines 0 comments Download
M sdk/lib/convert/utf.dart View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-22 08:48:33 UTC) #2
Søren Gjesse
lgtm
5 years, 8 months ago (2015-04-22 10:30:35 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-22 10:43:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698