sdk/lib/convert/utf.dart - Issue 1100873003: Avoid checking Uint8List for non-Latin-1 characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/convert/utf.dart

Issue 1100873003: Avoid checking Uint8List for non-Latin-1 characters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/convert/utf.dart

diff --git a/sdk/lib/convert/utf.dart b/sdk/lib/convert/utf.dart

index a58fb749971b33d16946252f842ed1b01ead5e32..9128e61a1a9c446b0bab931ed66ffe521cb21ed1 100644

--- a/sdk/lib/convert/utf.dart

+++ b/sdk/lib/convert/utf.dart

@@ -386,8 +386,6 @@ const int _SURROGATE_VALUE_MASK = 0x3FF;

const int _LEAD_SURROGATE_MIN = 0xD800;

const int _TAIL_SURROGATE_MIN = 0xDC00;

-bool _isSurrogate(int codeUnit) =>

- (codeUnit & _SURROGATE_MASK) == _LEAD_SURROGATE_MIN;

bool _isLeadSurrogate(int codeUnit) =>

(codeUnit & _SURROGATE_TAG_MASK) == _LEAD_SURROGATE_MIN;

bool _isTailSurrogate(int codeUnit) =>

@@ -396,7 +394,6 @@ int _combineSurrogatePair(int lead, int tail) =>

0x10000 + ((lead & _SURROGATE_VALUE_MASK) << 10)

| (tail & _SURROGATE_VALUE_MASK);

/**

* Decodes UTF-8.

« no previous file with comments | « sdk/lib/convert/latin1.dart ('k') | no next file » | no next file with comments »