Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1099663002: Reapply "Add tests for evalutating against activation records." (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
Cutch, WRONG ACCOUNT
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Reapply "Add tests for evalutating against activation records." Also kill the testee if the tester has an exceptions running its tests. BUG=http://dartbug.com/20047 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45305

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -2 lines) Patch
A runtime/observatory/tests/service/evaluate_activation_test.dart View 1 chunk +252 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 5 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
5 years, 8 months ago (2015-04-21 00:05:20 UTC) #2
Cutch
lgtm
5 years, 8 months ago (2015-04-21 01:00:44 UTC) #4
rmacnak
5 years, 8 months ago (2015-04-21 01:14:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698