Reapply "Add tests for evalutating against activation records."

runtime/observatory/tests/service/test_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked
 
 library test_helper;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'package:observatory/service_io.dart';
 
 bool _isWebSocketDisconnect(e) {
   if (e is! ServiceException) {
     return false;
   }
   return (e as ServiceException).message == 'WebSocket disconnected';
 }
 
 // This invocation should set up the state being tested.
 const String _TESTEE_MODE_FLAG = "--testee-mode";
 
 class _TestLauncher {
   Process process;
   final List<String> args;
+  bool killedByTester = false;
 
   _TestLauncher() : args = ['--enable-vm-service:0',
                             Platform.script.toFilePath(),
                             _TESTEE_MODE_FLAG] {}
 
   Future<int> launch(bool pause_on_exit) {
     String dartExecutable = Platform.executable;
     var fullArgs = [];
     if (pause_on_exit == true) {
       fullArgs.add('--pause-isolates-on-exit');
@@ skipping 25 matching lines @@
           first = false;
           print('** Signaled to run test queries on $portNumber');
         }
         print(line);
       });
       process.stderr.transform(UTF8.decoder)
                     .transform(new LineSplitter()).listen((line) {
         print(line);
       });
       process.exitCode.then((exitCode) {
+        if ((exitCode != 0) && !killedByTester) {
+          throw "Testee exited with $exitCode";
+        }
         print("** Process exited");
       });
       return completer.future;
     });
   }
 
   void requestExit() {
     print('** Killing script');
-    process.kill();
+    if (process.kill()) {
+      killedByTester = true;
+    }
   }
 }
 
 typedef Future IsolateTest(Isolate isolate);
 typedef Future VMTest(VM vm);
 
 /// Runs [tests] in sequence, each of which should take an [Isolate] and
 /// return a [Future]. Code for setting up state can run before and/or
 /// concurrently with the tests. Uses [mainArgs] to determine whether
 /// to run tests or testee in this invokation of the script.
@@ skipping 21 matching lines @@
       var name = Platform.script.pathSegments.last;
       runZoned(() {
         new WebSocketVM(new WebSocketVMTarget(addr)).load()
             .then((VM vm) => vm.isolates.first.load())
             .then((Isolate isolate) => Future.forEach(tests, (test) {
               print('Running $name [$testIndex/$totalTests]');
               testIndex++;
               return test(isolate);
             })).then((_) => process.requestExit());
       }, onError: (e, st) {
+        process.requestExit();
         if (!_isWebSocketDisconnect(e)) {
           print('Unexpected exception in service tests: $e $st');
           throw e;
         }
       });
     });
   }
 }
 
 
@@ skipping 40 matching lines @@
       var totalTests = tests.length;
       var name = Platform.script.pathSegments.last;
       runZoned(() {
         new WebSocketVM(new WebSocketVMTarget(addr)).load()
             .then((VM vm) => Future.forEach(tests, (test) {
               print('Running $name [$testIndex/$totalTests]');
               testIndex++;
               return test(vm);
             })).then((_) => process.requestExit());
       }, onError: (e, st) {
+        process.requestExit();
         if (!_isWebSocketDisconnect(e)) {
           print('Unexpected exception in service tests: $e $st');
           throw e;
         }
       });
     });
   }
 }