Issue 10990103: Remove dart2js specific core.dart/coreimpl.dart files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10990103: Remove dart2js specific core.dart/coreimpl.dart files. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove dart2js specific core.dart/coreimpl.dart files. Start using the shared lib/core/core.dart and lib/coreimpl/coreimpl.dart files. Change a few "interface" to "abstract class". Committed: https://code.google.com/p/dart/source/detail?r=13281

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -65 lines)			Patch
M	lib/_internal/libraries.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	lib/compiler/implementation/lib/core.dart	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	lib/compiler/implementation/lib/coreimpl.dart	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Depending on CL https://codereview.chromium.org/10967068/

8 years, 2 months ago (2012-09-28 08:52:09 UTC) #1

LGTM!!!

Expand Messages | Collapse Messages