Hide VM-only coreimpl List implementation types. These should not be

Hide VM-only coreimpl List implementation types. These should not be
exposed as visible parts of coreimpl.

Committed: https://code.google.com/p/dart/source/detail?r=12952

[Mads Ager (google), 2012-09-27 11:18:29]

Lasse, could you have a look at the whole thing.

Soren, could you have a look at dart:io stuff.

Anton, do you think the dart:html dartium changes will give us issues?

Florian, could you check that I have correctly dealt with the intrinsifier?

[Mads Ager (google), 2012-09-27 11:19:11]

Ivan: FYI.

[Lasse Reichstein Nielsen, 2012-09-27 11:34:13]

LGTM from a high-level perspective. If to works, it's fine.
Is this expected to have any affect on performance?

[Anton Muhin, 2012-09-27 11:34:54]

LGTM for Dartium part.  If there are any issues, it should be fixed on bindings
side.

[Mads Ager (google), 2012-09-27 11:45:11]

It should have very little performance impact. The only two things that I can
see that might have a performance impact are:

- map on ByteArrays no longer has the hooks to allocate a backing store of a
certain size for the initial growable List. I wouldn't expect this to be much of
an issue.

- sometimes a native call is needed to determine if we can avoid copying some
data in dart:io. However, compared to moving the data I expect that to have
minimal impact.

[Florian Schneider, 2012-09-27 11:45:54]

lgtm

https://codereview.chromium.org/10990055/diff/26/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/10990055/diff/26/runtime/vm/intrinsifier.h#ne...
runtime/vm/intrinsifier.h:60: GrowableObjectArray.fromObjectArray,              
                        \
Shouldn't there be an _ as well like in _Double.fromInteger?

_GrowableObjectArray.fromObjectArray

[Mads Ager (google), 2012-09-27 11:46:40]

https://codereview.chromium.org/10990055/diff/26/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/10990055/diff/26/runtime/vm/intrinsifier.h#ne...
runtime/vm/intrinsifier.h:60: GrowableObjectArray.fromObjectArray,              
                        \
On 2012/09/27 11:45:54, Florian Schneider wrote:
> Shouldn't there be an _ as well like in _Double.fromInteger?
> 
> _GrowableObjectArray.fromObjectArray

Yikes, good catch. Yes, there should. Similarly for 'ObjectArray.' above which
should be '_ObjectArray.'. Thanks!

[Søren Gjesse, 2012-09-27 12:18:20]

lgtm

https://codereview.chromium.org/10990055/diff/9003/runtime/bin/common.cc
File runtime/bin/common.cc (right):

https://codereview.chromium.org/10990055/diff/9003/runtime/bin/common.cc#newc...
runtime/bin/common.cc:15: Dart_LookupLibrary(Dart_NewString("dart:coreimpl"));
Do we want to keep these strings in persistent handles?

[Mads Ager (google), 2012-09-27 12:34:26]

https://codereview.chromium.org/10990055/diff/9003/runtime/bin/common.cc
File runtime/bin/common.cc (right):

https://codereview.chromium.org/10990055/diff/9003/runtime/bin/common.cc#newc...
runtime/bin/common.cc:15: Dart_LookupLibrary(Dart_NewString("dart:coreimpl"));
On 2012/09/27 12:18:20, Søren Gjesse wrote:
> Do we want to keep these strings in persistent handles?

Potentially. We don't do that with any other strings at this point. I'd like to
wait with this until we start profiling and see what is high on the list.