Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: runtime/lib/string_base.dart

Issue 10990055: Hide VM-only coreimpl List implementation types. These should not be (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: x64 as well, sigh. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/string_base.dart
diff --git a/runtime/lib/string_base.dart b/runtime/lib/string_base.dart
index cdfeff445d6db84483c366ebb17e8541712d1496..c31fdae3545b609397c52adb81f0f2237d7db7c6 100644
--- a/runtime/lib/string_base.dart
+++ b/runtime/lib/string_base.dart
@@ -20,12 +20,12 @@ class StringBase {
* [codePoints].
*/
static String createFromCharCodes(List<int> charCodes) {
- ObjectArray objectArray;
- if (charCodes is ObjectArray) {
+ _ObjectArray objectArray;
+ if (charCodes is _ObjectArray) {
objectArray = charCodes;
} else {
int len = charCodes.length;
- objectArray = new ObjectArray(len);
+ objectArray = new _ObjectArray(len);
for (int i = 0; i < len; i++) {
objectArray[i] = charCodes[i];
}
@@ -33,7 +33,7 @@ class StringBase {
return _createFromCodePoints(objectArray);
}
- static String _createFromCodePoints(ObjectArray<int> codePoints)
+ static String _createFromCodePoints(_ObjectArray<int> codePoints)
native "StringBase_createFromCodePoints";
String operator [](int index) native "String_charAt";
@@ -232,7 +232,7 @@ class StringBase {
*/
static String _interpolate(List values) {
int numValues = values.length;
- var stringList = new ObjectArray(numValues);
+ var stringList = new _ObjectArray(numValues);
for (int i = 0; i < numValues; i++) {
stringList[i] = values[i].toString();
}
@@ -336,12 +336,12 @@ class StringBase {
}
static String concatAll(List<String> strings) {
- ObjectArray stringsArray;
- if (strings is ObjectArray) {
+ _ObjectArray stringsArray;
+ if (strings is _ObjectArray) {
stringsArray = strings;
} else {
int len = strings.length;
- stringsArray = new ObjectArray(len);
+ stringsArray = new _ObjectArray(len);
for (int i = 0; i < len; i++) {
stringsArray[i] = strings[i];
}
@@ -349,7 +349,7 @@ class StringBase {
return _concatAll(stringsArray);
}
- static String _concatAll(ObjectArray<String> strings)
+ static String _concatAll(_ObjectArray<String> strings)
native "Strings_concatAll";
}

Powered by Google App Engine
This is Rietveld 408576698