Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 10984093: Remove support for impossible AST structure (and a couple of warnings) (Closed)

Created:
8 years, 2 months ago by Brian Wilkerson
Modified:
8 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for impossible AST structure (and a couple of warnings) Committed: https://code.google.com/p/dart/source/detail?r=13035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -36 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java View 2 chunks +0 lines, -25 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java View 1 chunk +1 line, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +3 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartScanner.java View 1 chunk +1 line, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
8 years, 2 months ago (2012-09-28 18:01:11 UTC) #1
scheglov
8 years, 2 months ago (2012-09-28 18:04:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698