compiler/java/com/google/dart/compiler/parser/DartScanner.java - Issue 10984093: Remove support for impossible AST structure (and a couple of warnings)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartScanner.java

Issue 10984093: Remove support for impossible AST structure (and a couple of warnings) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/DartParser.java ('k') | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/parser/DartScanner.java

===================================================================

--- compiler/java/com/google/dart/compiler/parser/DartScanner.java (revision 13031)

+++ compiler/java/com/google/dart/compiler/parser/DartScanner.java (working copy)

@@ -612,15 +612,12 @@

/**

* Called when comments are identified to aggregate the total number of comment lines and comment

- * characters then delegate to {@link #recordCommentLocation(int, int, int, int)}. This provides

+ * characters then delegate to {@link #recordCommentLocation(int, int)}. This provides

* a light weight way to track how much of the code is made up of comments without having to keep

* all comments.

* @param start the character position of the second character in the comment

* @param stop the character position of the final character in the comment

- * @param startLine the line number at <code>start</code>

- * @param endLine the line number of the last line of the comment

- * @param col the column number at <code>start</code>

private void commentLocation(int start, int stop) {

if (start <= lastCommentStart && stop <= lastCommentStop) {