Remove deoptimization index PC descriptors.

Remove deoptimization index PC descriptors.

Put the PC (offset) of the deoptimization point and the deoptimization
reason in the DeoptInfo table.  The table entries are now triples of
(PC offset, info, reason).

R=srdjan@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13056

[Kevin Millikin (Google), 2012-09-28 11:26:37]

This eliminates a level of indirection but doesn't save much space.  It enables
compaction of the deopt object table, which is the next change.

[srdjan, 2012-09-28 21:00:26]

LGTM with comments

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_descriptors.cc
File runtime/vm/code_descriptors.cc (left):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.cc:34: data.try_index = deopt_array_index;
Please add and use SetDeoptArrayIndex, so that multiple use of try_index is
defined in one place

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1463: }
Iniitialize deopt_info and deopt_reason to something reasonable if the info is
not found.

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:343: intptr_t i = 0;
You need to move the knowledge about the deopt_info_array structure to one
place, instead of distributing it over several.  Best would be to add it to
object.h like class DeoptInfo.

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:393: const int kEntrySize = 3;
Use a dedicated class to describe the structure of the array.

[Kevin Millikin (Google), 2012-10-01 09:38:56]

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1463: }
On 2012/09/28 21:00:26, srdjan wrote:
> Iniitialize deopt_info and deopt_reason to something reasonable if the info is
> not found.

OK, done.

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:343: intptr_t i = 0;
On 2012/09/28 21:00:26, srdjan wrote:
> You need to move the knowledge about the deopt_info_array structure to one
> place, instead of distributing it over several.  Best would be to add it to
> object.h like class DeoptInfo.

I stopped short of making it a subclass of Object.  I provided an AllStatic
DeoptTable class with utilities for reading entries, writing entries, and
getting the length of the table.

I put it it deopt_instructions.h, because there didn't seem to be anything else
like that (static utility class) in object.h.

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:393: const int kEntrySize = 3;
On 2012/09/28 21:00:26, srdjan wrote:
> Use a dedicated class to describe the structure of the array.

Done.

[srdjan, 2012-10-01 17:18:28]

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/10982088/diff/2001/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1463: }
On 2012/10/01 09:38:56, kmillikin wrote:
> On 2012/09/28 21:00:26, srdjan wrote:
> > Iniitialize deopt_info and deopt_reason to something reasonable if the info
is
> > not found.
> 
> OK, done.

Please upload your changes, before submitting, so that I can see them. Thanks!