Remove deoptimization index PC descriptors.

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
@@ skipping 319 matching lines @@
 
   OS::Print("PC Descriptors for function '%s' {\n", function_fullname);
   PcDescriptors::PrintHeaderString();
   const PcDescriptors& descriptors =
       PcDescriptors::Handle(code.pc_descriptors());
   OS::Print("%s}\n", descriptors.ToCString());
 
   const Array& deopt_info_array = Array::Handle(code.deopt_info_array());
   if (deopt_info_array.Length() > 0) {
     OS::Print("DeoptInfo: {\n");
-    for (intptr_t i = 0; i < deopt_info_array.Length(); i++) {
-      OS::Print("  %"Pd": %s\n",
-          i, Object::Handle(deopt_info_array.At(i)).ToCString());
+    Smi& offset = Smi::Handle();
+    DeoptInfo& info = DeoptInfo::Handle();
+    Smi& reason = Smi::Handle();
+    intptr_t i = 0;

[srdjan, 2012/09/28 21:00:26]

You need to move the knowledge about the deopt_info_array structure to one
place, instead of distributing it over several.  Best would be to add it to
object.h like class DeoptInfo.

[Kevin Millikin (Google), 2012/10/01 09:38:56]

I stopped short of making it a subclass of Object.  I provided an AllStatic
DeoptTable class with utilities for reading entries, writing entries, and
getting the length of the table.

I put it it deopt_instructions.h, because there didn't seem to be anything else
like that (static utility class) in object.h.

+    while (i < deopt_info_array.Length()) {
+      offset ^= deopt_info_array.At(i++);
+      info ^= deopt_info_array.At(i++);
+      reason ^= deopt_info_array.At(i++);
+      OS::Print("0x%"Px"  %s  (%s)\n",
+                start + offset.Value(),
+                info.ToCString(),
+                DeoptReasonToText(reason.Value()));
     }
     OS::Print("}\n");
   }
 
   const Array& object_table = Array::Handle(code.object_table());
   if (object_table.Length() > 0) {
     OS::Print("Object Table: {\n");
     for (intptr_t i = 0; i < object_table.Length(); i++) {
       OS::Print("  %"Pd": %s\n", i,
           Object::Handle(object_table.At(i)).ToCString());
@@ skipping 231 matching lines @@
     result = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
     isolate->set_long_jump_base(base);
     return result.raw();
   }
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart