Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10979053: Change many instance creation errors from compile-time errors to dynamic errors (Closed)

Created:
8 years, 2 months ago by regis
Modified:
8 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change many instance creation errors from compile-time errors to dynamic errors per revised spec (issue 3801). Add negative tests for factory redirection. Committed: https://code.google.com/p/dart/source/detail?r=12975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -89 lines) Patch
M runtime/vm/class_finalizer.h View 2 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 5 chunks +50 lines, -19 lines 0 comments Download
M runtime/vm/parser.cc View 8 chunks +91 lines, -64 lines 0 comments Download
M tests/co19/co19-runtime.status View 4 chunks +16 lines, -0 lines 0 comments Download
M tests/language/factory_redirection_test.dart View 3 chunks +26 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +10 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
8 years, 2 months ago (2012-09-27 17:17:53 UTC) #1
hausner
lgtm
8 years, 2 months ago (2012-09-27 17:47:24 UTC) #2
regis
8 years, 2 months ago (2012-09-27 17:53:14 UTC) #3
On 2012/09/27 17:47:24, hausner wrote:
> lgtm

Thanks!

Powered by Google App Engine
This is Rietveld 408576698