Change many instance creation errors from compile-time errors to dynamic errors

runtime/vm/class_finalizer.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CLASS_FINALIZER_H_
 #define VM_CLASS_FINALIZER_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 
@@ skipping 28 matching lines @@
                              // canonicalization are required; a malformed type
                              // is not tolerated.
   };
 
   // Finalize given type while parsing class cls.
   // Also canonicalize type if applicable.
   static RawAbstractType* FinalizeType(const Class& cls,
                                        const AbstractType& type,
                                        FinalizationKind finalization);
 
-  // Replace the malformed type with Dynamic and, depending on the given type
-  // finalization mode and execution mode, mark the type as malformed or report
-  // a compile time error. Prepend prev_error if not null.
+  // Allocate, finalize, and return a new malformed type as if it was declared
+  // in class cls at the given token position. Build the error message from the
+  // format string and its arguments.
+  static RawType* NewFinalizedMalformedType(const Class& cls,
+                                            intptr_t type_pos,
+                                            const char* format, ...)
+       PRINTF_ATTRIBUTE(3, 4);
+
+  // Depending on the given type, finalization mode, and execution mode, mark
+  // the given type as malformed or report a compile time error.
+  // If not null, prepend prev_error to the error message built from the format
+  // string and its arguments.
   static void FinalizeMalformedType(const Error& prev_error,
                                     const Class& cls,
                                     const Type& type,
                                     FinalizationKind finalization,
                                     const char* format, ...)
        PRINTF_ATTRIBUTE(5, 6);
 
   // Return false if we still have classes pending to be finalized.
   static bool AllClassesFinalized();
 
@@ skipping 31 matching lines @@
   static void ResolveType(const Class& cls,
                           const AbstractType& type,
                           FinalizationKind finalization);
   static void ResolveAndFinalizeUpperBounds(const Class& cls);
   static void ResolveAndFinalizeSignature(const Class& cls,
                                           const Function& function);
   static void ResolveAndFinalizeMemberTypes(const Class& cls);
   static void PrintClassInformation(const Class& cls);
   static void CollectInterfaces(const Class& cls,
                                 const GrowableObjectArray& interfaces);
+  static void ReportMalformedType(const Error& prev_error,
+                                  const Class& cls,
+                                  const Type& type,
+                                  FinalizationKind finalization,
+                                  const char* format,
+                                  va_list args);
   static void ReportError(const Error& error);
   static void ReportError(const Script& script,
                           intptr_t token_index,
                           const char* format, ...) PRINTF_ATTRIBUTE(3, 4);
   static void ReportError(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
 };
 
 }  // namespace dart
 
 #endif  // VM_CLASS_FINALIZER_H_