Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097723002: Type and constant propagator should guard against mutable class ids. (Closed)

Created:
5 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Type and constant propagator should guard against mutable class ids. Constant strings can be externalized so we can't fold away class checks against them. R=fschneider@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45243

Patch Set 1 #

Patch Set 2 : fix GuardField handling #

Total comments: 2

Patch Set 3 : Fix LoadStaticField #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -9 lines) Patch
M runtime/vm/constant_propagator.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 1 chunk +110 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 2 5 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Vyacheslav Egorov (Google)
5 years, 8 months ago (2015-04-17 15:08:23 UTC) #1
srdjan
lgtm
5 years, 8 months ago (2015-04-17 15:49:12 UTC) #3
Florian Schneider
LGTM. https://codereview.chromium.org/1097723002/diff/20001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/1097723002/diff/20001/runtime/vm/dart_api_impl_test.cc#newcode8859 runtime/vm/dart_api_impl_test.cc:8859: NULL); EXPECT_VALID(result); https://codereview.chromium.org/1097723002/diff/20001/runtime/vm/dart_api_impl_test.cc#newcode8899 runtime/vm/dart_api_impl_test.cc:8899: NULL); EXPECT_VALID(result);
5 years, 8 months ago (2015-04-17 15:54:17 UTC) #4
Vyacheslav Egorov (Google)
5 years, 8 months ago (2015-04-17 16:58:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698