Type and constant propagator should guard against mutable class ids.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
@@ skipping 8811 matching lines @@
                                    NewString("main"),
                                    0,
                                    NULL);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(260, value);
 }
 
 
+TEST_CASE(ExternalStringPolymorphicDeoptimize) {
+  const char* kScriptChars =
+      "const strA = 'AAAA';\n"
+      "class A {\n"
+      "  static change_str(String s) native 'A_change_str';\n"
+      "}\n"
+      "compare(a, b, [i = 0]) {\n"
+      "  return a.codeUnitAt(i) == b.codeUnitAt(i);\n"
+      "}\n"
+      "compareA(b, [i = 0]) {\n"
+      "  return compare(strA, b, i);\n"
+      "}\n"
+      "main() {\n"
+      "  var externalA = 'AA' + 'AA';\n"
+      "  A.change_str(externalA);\n"
+      "  compare('AA' + 'AA', strA);\n"
+      "  compare(externalA, strA);\n"
+      "  for (var i = 0; i < 10000; i++) compareA(strA);\n"
+      "  A.change_str(strA);\n"
+      "  return compareA('AA' + 'AA');\n"
+      "}\n";
+  Dart_Handle lib =
+      TestCase::LoadTestScript(kScriptChars,
+                               &ExternalStringDeoptimize_native_lookup);
+  Dart_Handle result = Dart_Invoke(lib,
+                                   NewString("main"),
+                                   0,
+                                   NULL);

[Florian Schneider, 2015/04/17 15:54:17]

EXPECT_VALID(result);

+  bool value = false;
+  result = Dart_BooleanValue(result, &value);
+  EXPECT_VALID(result);
+  EXPECT(value);
+}
+
+
+TEST_CASE(ExternalStringGuardFieldDeoptimize) {
+  const char* kScriptChars =
+      "const strA = 'AAAA';\n"
+      "class A {\n"
+      "  static change_str(String s) native 'A_change_str';\n"
+      "}\n"
+      "class G { var f = 'A'; }\n"
+      "final guard = new G();\n"
+      "var shouldExternalize = false;\n"
+      "ext() { if (shouldExternalize) A.change_str(strA); }\n"
+      "compare(a, b, [i = 0]) {\n"
+      "  guard.f = a;\n"
+      "  ext();"
+      "  return a.codeUnitAt(i) == b.codeUnitAt(i);\n"
+      "}\n"
+      "compareA(b, [i = 0]) {\n"
+      "  return compare(strA, b, i);\n"
+      "}\n"
+      "main() {\n"
+      "  var externalA = 'AA' + 'AA';\n"
+      "  A.change_str(externalA);\n"
+      "  compare('AA' + 'AA', strA);\n"
+      "  for (var i = 0; i < 10000; i++) compareA(strA);\n"
+      "  shouldExternalize = true;\n"
+      "  return compareA('AA' + 'AA');\n"
+      "}\n";
+  Dart_Handle lib =
+      TestCase::LoadTestScript(kScriptChars,
+                               &ExternalStringDeoptimize_native_lookup);
+  Dart_Handle result = Dart_Invoke(lib,
+                                   NewString("main"),
+                                   0,
+                                   NULL);

[Florian Schneider, 2015/04/17 15:54:17]

EXPECT_VALID(result);

+  bool value = false;
+  result = Dart_BooleanValue(result, &value);
+  EXPECT_VALID(result);
+  EXPECT(value);
+}
+
+
 TEST_CASE(ExternalStringTrimDoubleParse) {
   const char* kScriptChars =
       "String str = 'A';\n"
       "class A {\n"
       "  static change_str(String s) native 'A_change_str';\n"
       "}\n"
       "main() {\n"
       "  var externalOneByteString = ' 0.2\\xA0 ';\n;"
       "  A.change_str(externalOneByteString);\n"
       "  var externalTwoByteString = ' \\u{2029}0.6\\u{2029} ';\n"
@@ skipping 163 matching lines @@
     result = Dart_Invoke(lib,
                          NewString("testView16"),
                          1,
                          dart_args);
     EXPECT_VALID(result);
     EXPECT(Dart_IsString(result));
   }
 }
 
 }  // namespace dart