Parameterize 'new Options().script'.

Parameterize 'new Options().script'.

Committed: https://code.google.com/p/dart/source/detail?r=12763

[ahe, 2012-09-24 09:03:49]

I need this to create my own main program that test co19 in various
configurations.

My script will be located in dart/tools/testing/dart/co19_test.dart (but not in
this CL), and this indirection allows my to tell the overall test framework
where to find test.dart.

I don't think this is the cleanest solution, but I really need this to work now,
and I do not have time to refactor test.dart. If you feel so inclined, please go
ahead and refactor test.dart, but please don't block me from making progress on
this. I'm already a week behind on updating co19, and we really need an
up-to-date test suite for M1 language work.

[Mads Ager (google), 2012-09-24 09:23:42]

LGTM

Which configurations do you need for co19 tests that do not fit into the current
test.dart configurations?

[William Hesse, 2012-09-24 09:26:41]

LGTM.

You didn't tell me that there were three other uses of Options.script, that
needed to be changed to this.  That is why I proposed a different solution for
TestUtils.dartDir - I thought it was the only place you were using the variable.

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:1245: static String testScriptPath = new
Options().script;
Comment this, that the test scripts depend on this being a script in the
dart/tools directory, and that if the main script using test_suite.dart is not
there, the main script must set this to dart/tools/test.dart.

[ahe, 2012-09-24 09:33:33]

On 2012/09/24 09:23:42, Mads Ager wrote:
> LGTM
> 
> Which configurations do you need for co19 tests that do not fit into the
current
> test.dart configurations?

I'm trying to create a program which wraps these commands:

test.py --report -pcolor --time -mrelease,debug -rvm -cnone co19
test.py --report -pcolor --time -mrelease,debug -rvm -cnone --checked co19
test.py --report -pcolor --time -mrelease -rnone -cdartc co19
test.py --report -pcolor --time -mrelease -rd8 -cdart2js co19
test.py --report -pcolor --time -mrelease -rd8 -cdart2js --checked co19

I'm currently testing this and it seems to work. Incrementally, I'll add more
features to help automating upgrading the co19 test suite.

[ahe, 2012-09-24 09:41:44]

Thank you, Bill and Mads!

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:1245: static String testScriptPath = new
Options().script;
On 2012/09/24 09:26:41, William Hesse wrote:
> Comment this, that the test scripts depend on this being a script in the
> dart/tools directory, and that if the main script using test_suite.dart is not
> there, the main script must set this to dart/tools/test.dart.

Done.

[Bob Nystrom, 2012-09-24 17:23:50]

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:1245: static String testScriptPath = new
Options().script;
On 2012/09/24 09:26:41, William Hesse wrote:
> Comment this, that the test scripts depend on this being a script in the
> dart/tools directory, and that if the main script using test_suite.dart is not
> there, the main script must set this to dart/tools/test.dart.

Is this another case where http://code.google.com/p/dart/issues/detail?id=1145
would help?

[ahe, 2012-09-24 17:27:49]

On 2012/09/24 17:23:50, Bob Nystrom wrote:
>
https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
> File dart/tools/testing/dart/test_suite.dart (right):
> 
>
https://codereview.chromium.org/10970060/diff/1/dart/tools/testing/dart/test_...
> dart/tools/testing/dart/test_suite.dart:1245: static String testScriptPath =
new
> Options().script;
> On 2012/09/24 09:26:41, William Hesse wrote:
> > Comment this, that the test scripts depend on this being a script in the
> > dart/tools directory, and that if the main script using test_suite.dart is
not
> > there, the main script must set this to dart/tools/test.dart.
> 
> Is this another case where http://code.google.com/p/dart/issues/detail?id=1145
> would help?

Possibly. But generally, I think the Options API is hard to use without painting
yourself into a corner. A reusable app will do the following:

main() {
  appMain(new Options());
}

appMain(Options options) {
  // Stuff that would normally go into main.
}