Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: dart/tools/testing/dart/test_runner.dart

Issue 10970060: Parameterize 'new Options().script'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dart/tools/testing/dart/drt_updater.dart ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1077 } 1077 }
1078 }; 1078 };
1079 } 1079 }
1080 1080
1081 /** 1081 /**
1082 * For browser tests using Safari or Opera, we need to use the Selenium 1.0 1082 * For browser tests using Safari or Opera, we need to use the Selenium 1.0
1083 * Java server. 1083 * Java server.
1084 */ 1084 */
1085 void _startSeleniumServer() { 1085 void _startSeleniumServer() {
1086 // Get the absolute path to the Selenium jar. 1086 // Get the absolute path to the Selenium jar.
1087 String filePath = new Options().script; 1087 String filePath = TestUtils.testScriptPath;
1088 String pathSep = Platform.pathSeparator; 1088 String pathSep = Platform.pathSeparator;
1089 int index = filePath.lastIndexOf(pathSep); 1089 int index = filePath.lastIndexOf(pathSep);
1090 filePath = '${filePath.substring(0, index)}${pathSep}testing${pathSep}'; 1090 filePath = '${filePath.substring(0, index)}${pathSep}testing${pathSep}';
1091 var lister = new Directory(filePath).list(); 1091 var lister = new Directory(filePath).list();
1092 lister.onFile = (String file) { 1092 lister.onFile = (String file) {
1093 if (const RegExp(r"selenium-server-standalone-.*\.jar").hasMatch(file) 1093 if (const RegExp(r"selenium-server-standalone-.*\.jar").hasMatch(file)
1094 && _seleniumServer == null) { 1094 && _seleniumServer == null) {
1095 _seleniumServer = Process.start('java', ['-jar', file]); 1095 _seleniumServer = Process.start('java', ['-jar', file]);
1096 _seleniumServer.onError = (e) { 1096 _seleniumServer.onError = (e) {
1097 print("Error starting process:"); 1097 print("Error starting process:");
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1186 // the developer doesn't waste his or her time trying to fix a bunch of 1186 // the developer doesn't waste his or her time trying to fix a bunch of
1187 // tests that appear to be broken but were actually just flakes that 1187 // tests that appear to be broken but were actually just flakes that
1188 // didn't get retried because there had already been one failure. 1188 // didn't get retried because there had already been one failure.
1189 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1189 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1190 new RunningProcess(test, allowRetry, this).start(); 1190 new RunningProcess(test, allowRetry, this).start();
1191 } 1191 }
1192 _numProcesses++; 1192 _numProcesses++;
1193 } 1193 }
1194 } 1194 }
1195 } 1195 }
OLDNEW
« no previous file with comments | « dart/tools/testing/dart/drt_updater.dart ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698