Issue 10970015: Throw an exception when invalid source file location is encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10970015: Throw an exception when invalid source file location is encountered. (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Throw an exception when invalid source file location is encountered. Currently, compiler is crashed in SourceMapBuilder with unhelpful stack trace. Throwing an exception in ssa builder will help us to fix crashes that occur in the wild. R=ahe@google.com,kasperl@google.com BUG=5184 Committed: https://code.google.com/p/dart/source/detail?r=12765

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -10 lines)			Patch
M	lib/compiler/implementation/source_map_builder.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	3 chunks	+21 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View	1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! http://codereview.chromium.org/10970015/diff/1/lib/compiler/implementation/warnings.dart File lib/compiler/implementation/warnings.dart (right): http://codereview.chromium.org/10970015/diff/1/lib/compiler/implementation/warnings.dart#newcode258 lib/compiler/implementation/warnings.dart:258: static const INVALID_SOURCE_FILE_LOCATION = const MessageKind(''' Please add ...

8 years, 2 months ago (2012-09-24 08:54:18 UTC) #2

podivilov

8 years, 2 months ago (2012-09-24 09:44:01 UTC) #3

http://codereview.chromium.org/10970015/diff/1/lib/compiler/implementation/wa...
File lib/compiler/implementation/warnings.dart (right):

http://codereview.chromium.org/10970015/diff/1/lib/compiler/implementation/wa...
lib/compiler/implementation/warnings.dart:258: static const
INVALID_SOURCE_FILE_LOCATION = const MessageKind('''
On 2012/09/24 08:54:18, ahe wrote:
> Please add this above COMPILER_CRASHED.

Done.

Expand Messages | Collapse Messages