Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: lib/compiler/implementation/source_map_builder.dart

Issue 10970015: Throw an exception when invalid source file location is encountered. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/source_map_builder.dart
diff --git a/lib/compiler/implementation/source_map_builder.dart b/lib/compiler/implementation/source_map_builder.dart
index f82b275ab173248a5d650a18df913418307dc23b..0b081ac69b32be759a1c436ca910b256fff260b0 100644
--- a/lib/compiler/implementation/source_map_builder.dart
+++ b/lib/compiler/implementation/source_map_builder.dart
@@ -155,7 +155,7 @@ class SourceFileLocation {
int line;
SourceFileLocation(this.sourceFile, this.token) {
- assert(token.charOffset < sourceFile.text.length);
+ assert(isValid());
}
String getSourceUrl() => sourceFile.filename;
@@ -171,4 +171,6 @@ class SourceFileLocation {
if (token.isIdentifier()) return token.slowToString();
return null;
}
+
+ bool isValid() => token.charOffset < sourceFile.text.length;
}
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/builder.dart » ('j') | lib/compiler/implementation/warnings.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698